[wp-trac] [WordPress Trac] #36549: Space in attachment filename breaks srcset
WordPress Trac
noreply at wordpress.org
Fri May 6 18:58:47 UTC 2016
#36549: Space in attachment filename breaks srcset
--------------------------+------------------------------
Reporter: underdude | Owner: joemcgill
Type: defect (bug) | Status: reviewing
Priority: normal | Milestone: Awaiting Review
Component: Media | Version: trunk
Severity: normal | Resolution:
Keywords: | Focuses:
--------------------------+------------------------------
Comment (by joemcgill):
Hi @underdude,
Thanks for the added explanation. Since this seems to be an edge case that
doesn't occur in core directly, but is related to improperly formed file
names using `wp_insert_attachment()`, I think we should consider adding a
patch there, but not in `wp_calculate_image_srcset()`. Reason being, we're
attempting to keep `wp_calculate_image_srcset()` as lean as possible since
it's used via a content filter on the front end.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/36549#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list