[wp-trac] [WordPress Trac] #14730: ms-files.php required ob_clean() and flush()

[WordPress Trac]

#14730: ms-files.php required ob_clean() and flush()
--------------------------+--------------------------
 Reporter:  pj_mfc        |       Owner:  iamfriendly
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.6
Component:  Multisite     |     Version:  4.2.2
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  multisite
--------------------------+--------------------------

Comment (by iamfriendly):

 Replicating this delightful issue isn’t easy. It doesn’t appear to happen
 on every upgrade. Nailing down exactly ''why'' it happens appears to be
 beyond me.

 However, the patch — as-is — doesn’t ‘break’ anything as far as I can
 tell. It seems harmless. After applying it, and running several upgrades,
 I haven’t been able to replicate the broken images. :tada:

 That being said, I’m starting to think that an even safer strategy is to
 add actions before and after the `readfile()` rather than some magic
 flushing. This way, the change would be completely benign on our part, and
 if the flushing/cleaning is the answer to all life’s problems for some
 installs, then it can be added in a mu-plugin for those affected.
 Thoughts?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/14730#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform