[wp-trac] [WordPress Trac] #34905: zxcvbn() not defined (and making it impossible to edit an existing user)

[WordPress Trac]

#34905: zxcvbn() not defined (and making it impossible to edit an existing user)
--------------------------+------------------------------
 Reporter:  wp-plugin@…   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Users         |     Version:  4.3.1
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  javascript
--------------------------+------------------------------
Changes (by peterwilsoncc):

 * keywords:  needs-patch => has-patch


Comment:

 This slipped my mind way back when, here's a first pass at solving the
 race condition on slow networks.

 In [attachment:34905.diff]:

 * `wp.passwordStrength.meter` fails gracefully if `zxcvbn` is undefined.
 * Password strength indicator warns password strength is unknown
 * user needs to accept the use of a potentially week password
 * If the user enters a new password prior to the library loading:
   - no password is generated
   - password strength indicator updates once the library is ready

 To test, open the network tab in Chrome dev tools, disable caching and
 throttle the network speed to 2G.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34905#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform