[wp-trac] [WordPress Trac] #36754: Apply new Dashicon to Multisite

WordPress Trac noreply at wordpress.org
Thu May 5 12:06:37 UTC 2016


#36754: Apply new Dashicon to Multisite
---------------------------------------+----------------------------
 Reporter:  Ipstenu                    |       Owner:  jeremyfelt
     Type:  enhancement                |      Status:  reopened
 Priority:  normal                     |   Milestone:  4.6
Component:  Administration             |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:  ui, multisite
---------------------------------------+----------------------------

Comment (by johnjamesjacoby):

 Replying to [comment:10 ocean90]:
 > dashicons.css is an external-ish file and shouldn't be changed in core
 without changing it [https://github.com/wordpress/dashicons upstream] too.
 >
 > The class for the new icon is `.dashicons-admin-multisite` and should be
 used for the menu instead, see [attachment:37362.patch].
 Ugh. I totally forgot about that.

 Your patch seems incorrect, unless I'm reading it wrong. We do not want to
 change the `network` dashicon, we only want to implement the multisite
 dashicon where it was intended.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36754#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list