[wp-trac] [WordPress Trac] #36724: who=>authors breaks meta arguments in user queries

[WordPress Trac]

#36724: who=>authors breaks meta arguments in user queries
-------------------------------------------------+-------------------------
 Reporter:  Rarst                                |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  4.6
Component:  Users                                |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  needs-unit-tests good-first-bug      |     Focuses:
  needs-patch                                    |
-------------------------------------------------+-------------------------
Changes (by boonebgorges):

 * keywords:  needs-unit-tests good-first-bug dev-feedback has-patch 2nd-
     opinion => needs-unit-tests good-first-bug needs-patch
 * milestone:  Awaiting Review => 4.6


Comment:

 Thanks, @adrianosilvaferreira. This patch is looking closer. However, the
 way you've structured it, a 'who' parameter will override any 'meta_query'
 passed to the function. You will need to assemble a meta query clause for
 the 'who' stuff, and then append it to the value of 'meta_query', in the
 same way that we do with the `$role_queries` clause in the same method.

 We will also need unit tests that demonstrate that 'meta_query' and 'who'
 work together properly.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36724#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform