[wp-trac] [WordPress Trac] #35664: Edit term screens: tab order should match visual order
WordPress Trac
noreply at wordpress.org
Tue May 3 19:30:43 UTC 2016
#35664: Edit term screens: tab order should match visual order
----------------------------------------------+----------------------------
Reporter: afercia | Owner: afercia
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.6
Component: Taxonomy | Version:
Severity: normal | Resolution:
Keywords: has-screenshots has-patch commit | Focuses: ui,
| accessibility
----------------------------------------------+----------------------------
Changes (by afercia):
* keywords: has-screenshots ui-feedback has-patch => has-screenshots has-
patch commit
Comment:
Replying to [comment:13 joedolson]:
> It looks like a problem in the list table class passing 0 as the colspan
value for the quick edit form.
Yeah, Polylang adds a table in these screens and with the patch applied it
becomes the first table in the source. The `.widefat:first thead` jQuery
selector used to get the count of the visible columns to be used as the
value to set on the Quick Edit table cell `colspan` attribute assumed the
WP list table to be the first table in the source. Which now it may be not
true, giving the different order of the hooks in the source.
The refreshed patch uses a more specific jQuery selector to fix the issue.
About the action hooks, the order is now different of course but basically
just one changed:
{{{
do_action( "after-{$taxonomy}-table", $taxonomy );
}}}
is the only action hook in the "right column" and it was the first one to
fire. With the patch applied, it's the last one.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35664#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list