[wp-trac] [WordPress Trac] #35791: WP_Site_Query class

WordPress Trac noreply at wordpress.org
Mon May 2 23:14:31 UTC 2016


#35791: WP_Site_Query class
-------------------------------------------------+-------------------------
 Reporter:  spacedmonkey                         |       Owner:  jeremyfelt
     Type:  task (blessed)                       |      Status:  reviewing
 Priority:  normal                               |   Milestone:  4.6
Component:  Networks and Sites                   |     Version:  4.4
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-unit-  |     Focuses:  multisite
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by spacedmonkey):

 35791-implementation.3.patch fixes some bugs/inconsistencies and includes
 minor improvements to make the unit tests pass.
 {{{#!php
 $args = array(
                 'path__in'   => $paths,
                 'domain__in' => $domains,
                 'number'     => 1
         );
 }}}
 ms-load.php. Line 237. Fix, change path, to paths.

 {{{#!php
         if( is_array( $args['network_id'] ) ){
                 $args['network__in'] = $args['network_id'];
                 $args['network_id'] = null;
         }

         if( is_numeric( $args['limit'] ) ){
                 $args['number'] = $args['limit'];
                 $args['limit'] = null;
         }
 }}}
 ms-functions.php Line 2471. Backwards comp in wp_get_sites.

 {{{#!php
 $result = get_sites( array(
                 'path'    => $path,
                 'domain'  => $domain,
                 'network_id' => $site_id,
                 'number'  => 1,
                 'fields'  => 'ids'
         ) );
 }}}
 ms-functions.php Line 1264. Changed network to network_id.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35791#comment:35>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list