[wp-trac] [WordPress Trac] #36571: Add `$comment` parameter to `get_comment_author_email_link()`
WordPress Trac
noreply at wordpress.org
Mon May 2 18:48:44 UTC 2016
#36571: Add `$comment` parameter to `get_comment_author_email_link()`
--------------------------------------+------------------
Reporter: flixos90 | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 4.6
Component: Comments | Version: 2.7
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+------------------
Comment (by boonebgorges):
[attachment:36571.5.diff] makes the following changes to
[attachment:36571.4.diff] :
- Share the same comment fixture across the new tests (using
`wpSetUpBeforeClass()` etc)
- During test teardown, clear the `$comment` global and readd the
`antispambot` filter, to avoid test pollution
- Use `null` for a default value of the new param rather than `0`
- Only use the `@ticket` flag for test methods that are directly related
to the enhancement being introduced here
Changes are looking good to me.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/36571#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list