[wp-trac] [WordPress Trac] #33055: Support Parallel HTTP Requests in WP_Http, et al

WordPress Trac noreply at wordpress.org
Mon May 2 01:12:58 UTC 2016


#33055: Support Parallel HTTP Requests in WP_Http, et al
------------------------------------------+--------------------------
 Reporter:  wonderboymusic                |       Owner:  rmccue
     Type:  task (blessed)                |      Status:  assigned
 Priority:  high                          |   Milestone:  4.6
Component:  HTTP API                      |     Version:
 Severity:  normal                        |  Resolution:
 Keywords:  dev-feedback has-patch early  |     Focuses:  performance
------------------------------------------+--------------------------

Comment (by dd32):

 Replying to [comment:25 ocean90]:
 > Replying to [comment:24 dd32]:
 > > After reading through [attachment:33055.3.diff] the only real concern
 I have so far is the duplication of the SSL Certificates file.
 >
 > Isn't the "in the middle" part that we pass WP's certificates to
 Requests per default if one of the wp_remote_* functions is used?

 If a plugin, or an external package used within a plugin, uses
 `Requests::` directly then unless we ship the ca-bundle with Requests too
 then it'll be unable to SSL.

 So we could rely upon Requests bundled SSL certs instead (and update it as
 need be), but if we remove our copy of it and a plugin is referencing it
 directly, things could break.

 There's two possible options in my mind:
 a) in `wp_remote_*` detect if `wp-includes/certificate/*` was passed in,
 and if so, ignore the parameter
 b) in `Requests` allow some way of defining the path to the SSL certs
 (@rmccue's idea there) - either through one of the ini settings PHP has in
 modern versions, through a constant, or a static property on `Requests`
 etc.
 I'm leaving that part up to @rmccue's best judgement

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33055#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list