[wp-trac] [WordPress Trac] #36236: JS error & odd behaviour when attempting to set image as 'site icon'

[WordPress Trac]

#36236: JS error & odd behaviour when attempting to set image as 'site icon'
--------------------------+-------------------------
 Reporter:  davetgreen    |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.6
Component:  Customize     |     Version:  4.4.2
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  javascript
--------------------------+-------------------------
Changes (by celloexpressions):

 * keywords:  reporter-feedback => has-patch
 * milestone:  Awaiting Review => 4.6


Comment:

 `controller` is supposed to be `controller.frame` in this case, see patch.
 `controller` is the customizer control object, but in this case it should
 actually be the media frame (`controller.frame`). I can confirm that this
 change prevents a JS error from being thrown, although it doesn't provide
 information on the error to the user. If nothing else though, let's get
 the JS error fix in.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36236#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform