[wp-trac] [WordPress Trac] #33932: Filters for Plugin/Theme Update Email Notifications

[WordPress Trac]

#33932: Filters for Plugin/Theme Update Email Notifications
-------------------------------------------------+-------------------------
 Reporter:  ronalfy                              |       Owner:
     Type:  enhancement                          |  johnbillion
 Priority:  normal                               |      Status:  reopened
Component:  Upgrade/Install                      |   Milestone:  4.6
 Severity:  normal                               |     Version:  3.7
 Keywords:  has-patch has-unit-tests needs-      |  Resolution:
  refresh                                        |     Focuses:
-------------------------------------------------+-------------------------
Changes (by ocean90):

 * keywords:  has-patch has-unit-tests => has-patch has-unit-tests needs-
     refresh


Comment:

 Some feedback about [attachment:33932.patch]:

 * The doc block for `send_update_notification_email` needs to be aligned
 with a whitespace before the `*`.
 * The documentation should start with "Filter whether to".
 * It seems like the current documentation was copied from the
 `send_core_update_notification_email` filter. The new filter should have
 its own documentation because the current one is wrong.
 * It's also worth to mention, that the suggested filter lives in
 `send_debug_email`, naming it `send_update_notification_email` feels
 wrong.
 * Changes to tests/phpunit/tests/mail.php should be part of a separate
 ticket. It seems like [37307] fixed parts of this already.
 * In `test_send_update_notification_email_filter_no_emails()` the comment
 for `send_update_notification_email` should be just `// Disable all
 notifications.`
 * In `test_send_update_notification_email_filter_remove_single_type()` the
 comment for `send_update_notification_email` is wrong (copy/paste error).
 * In `test_send_update_notification_email_filter_remove_single_type()` the
 variable variable `$$type` looks odd. The alignment should be improved
 too.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33932#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform