[wp-trac] [WordPress Trac] #36337: Shift-Click to Edit on Custom Logo selects "Remove" button.

WordPress Trac noreply at wordpress.org
Mon Mar 28 14:22:17 UTC 2016


#36337: Shift-Click to Edit on Custom Logo selects "Remove" button.
--------------------------+--------------------------------
 Reporter:  mikeschroder  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  ui, accessibility
--------------------------+--------------------------------

Comment (by adamsilverstein):

 Replying to [comment:4 westonruter]:
 > Instead of a `focus-first` class name I suggest something like `control-
 focus`, as it is the element which receives focus when the control's
 `focus` method is called. See [attachment:36337.3.diff], which also
 simplifies some of the logic.

 Good suggestion; thanks for the review and simplified code.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36337#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list