[wp-trac] [WordPress Trac] #36327: Custom logo: the image size argument is not taking in account
WordPress Trac
noreply at wordpress.org
Sun Mar 27 13:50:05 UTC 2016
#36327: Custom logo: the image size argument is not taking in account
--------------------------+-----------------------
Reporter: imath | Owner: obenland
Type: defect (bug) | Status: reopened
Priority: normal | Milestone:
Component: Themes | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
--------------------------+-----------------------
Changes (by imath):
* status: closed => reopened
* resolution: invalid =>
Comment:
@obenland @ocean90
Fine, but then why using `get_theme_support( 'custom-logo', 'size' );` in
the function `get_custom_logo()` as it's not possible to specify this size
with add_theme_support() anymore ??
see https://core.trac.wordpress.org/browser/trunk/src/wp-includes/general-
template.php#L879
It seems weird to me to use a function that can't return anything set by
the theme....
So to be consistent i think you should allow the size argument or remove
this `get_theme_support( 'custom-logo', 'size' );` part...
--
Ticket URL: <https://core.trac.wordpress.org/ticket/36327#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list