[wp-trac] [WordPress Trac] #36337: Shift-Click to Edit on Custom Logo selects "Remove" button.

WordPress Trac noreply at wordpress.org
Fri Mar 25 23:59:14 UTC 2016

#36337: Shift-Click to Edit on Custom Logo selects "Remove" button.
 Reporter:  mikeschroder             |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Customize                |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  needs-patch 2nd-opinion  |     Focuses:  ui, accessibility

Comment (by adamsilverstein):

 This happens because the focus is designed to hit the first visible button
 or link.

 [attachment:36337.diff] fixes this by explicitly excluding elements with
 the class `remove-button`. After applying the patch, shift clicking the
 logo focuses the 'Change Logo' button. This may not be the best solution;
 I think a more robust solution would enable sections to specify a focus
 target that would override the default 'first button' behavior.


Ticket URL: <https://core.trac.wordpress.org/ticket/36337#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list