[wp-trac] [WordPress Trac] #35878: In `wp.media.view.Attachment.render` tested parameter is missing a default.

WordPress Trac noreply at wordpress.org
Fri Mar 25 05:27:20 UTC 2016


#35878: In `wp.media.view.Attachment.render` tested parameter is missing a default.
-----------------------------------+------------------------------
 Reporter:  georgestephanis        |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  lowest                 |   Milestone:  Awaiting Review
Component:  Media                  |     Version:  4.2
 Severity:  minor                  |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:  javascript
-----------------------------------+------------------------------

Comment (by adamsilverstein):

 @georgestephanis Thanks for the bug report, glad to see you tinkering in
 the media JS.

 I'm not sure we need to define nonces here or what the default would be.
 nonces are passed in the options (as are many other fields missing from
 [http://cl.ly/031U2s1A1o2a/Media_Library__10up_BUC__WordPress_2016-03-24_23-20-16.jpg
 the defaults ]), but do they really have a logical default except null or
 undefined?

 your IDE settings may need some adjusting :) what specifically is its
 cranky complaint and what are you linting with?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35878#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list