[wp-trac] [WordPress Trac] #35960: Remove excess padding from .nav-tab-wrapper

[WordPress Trac]

#35960: Remove excess padding from .nav-tab-wrapper
---------------------------------------+---------------------------------
 Reporter:  ericdaams                  |       Owner:  ocean90
     Type:  defect (bug)               |      Status:  accepted
 Priority:  normal                     |   Milestone:  4.5
Component:  Administration             |     Version:  trunk
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:  ui, administration
---------------------------------------+---------------------------------
Description changed by ocean90:

Old description:

> When an H1 is used for tabs with `.nav-tab-wrapper`, there is excess
> padding between the tabs & border.
>
> Noted this issue with the Settings pages of the following plugins, but it
> will be the case with any other plugin that uses an H1 on the `.nav-tab-
> wrapper`:
>
> * Easy Digital Downloads
> * Charitable
> * Give
>
> If there is an accessibility/semantic reason for '''not''' using an H1 on
> the `.nav-tab-wrapper`, I will happily change this in Charitable (my
> plugin), but I think a small patch here wouldn't hurt to account for
> plugins that don't update.
>
> Likely related to https://core.trac.wordpress.org/ticket/33559

New description:

 When an H1 is used for tabs with `.nav-tab-wrapper`, there is excess
 padding between the tabs & border.

 Noted this issue with the Settings pages of the following plugins, but it
 will be the case with any other plugin that uses an H1 on the `.nav-tab-
 wrapper`:

 * Easy Digital Downloads
 * Charitable
 * Give

 If there is an accessibility/semantic reason for '''not''' using an H1 on
 the `.nav-tab-wrapper`, I will happily change this in Charitable (my
 plugin), but I think a small patch here wouldn't hurt to account for
 plugins that don't update.

 Likely related to #33559

--

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35960#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform