[wp-trac] [WordPress Trac] #36255: Custom Logo: Crop UI

[WordPress Trac]

#36255: Custom Logo: Crop UI
--------------------------+-----------------------
 Reporter:  mor10         |       Owner:  obenland
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.5
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  ui
--------------------------+-----------------------

Comment (by celloexpressions):

 Cross-posting from slack for reference:
 - Re: supporting `size` - should core be providing back-compat for
 Jetpack? It won't break anything, the size just wouldn't be exactly what
 the theme selected but the feature still works. Also, this encourages a
 potentially wasteful practice of registering an image size that would only
 be used for one image but created for every image uploaded to the site.
 - [attachment:36255.diff] looks like it would require explicitly
 specifying both flex-width and flex-height, I think it would be better to
 let it work if only a width and height are specified and fall back to
 defaults (true) for those two if they aren't included.
 - [attachment:36255.diff] - I don't think we should allow control args to
 be overwritten be the theme support array (via wp_parse_args), only the
 four size options. Otherwise, the add theme support starts to become more
 like a customizer add_control, and things can be changes that shouldn't be
 from there. Also seems like a potential security issue to be able to pass
 anything else in there.
 - We should update Twenty Fifteen to not use `size` due to the unnecessary
 image generation and to allow flex-height, per [attachment:36255.6.diff].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36255#comment:45>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform