[wp-trac] [WordPress Trac] #35715: edit_user() doesn't check for empty password (pass1).

[WordPress Trac]

#35715: edit_user() doesn't check for empty password (pass1).
-------------------------------------------------+-------------------------
 Reporter:  gitlost                              |       Owner:  ocean90
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  4.5
Component:  Users                                |     Version:  4.4
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-patch has-        |     Focuses:
  screenshots                                    |
-------------------------------------------------+-------------------------

Comment (by ocean90):

 Replying to [comment:19 adamsilverstein]:
 > Replying to [comment:18 ocean90]:
 > > We can probably use `strlen( $pass )` here.
 >
 > good point, is that more performant or easier to understand?

 It catches false, null and '', but not 0 or '0'. So yeah, easier to
 understand but also more accurate IMO.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35715#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform