[wp-trac] [WordPress Trac] #35715: edit_user() doesn't check for empty password (pass1).

WordPress Trac noreply at wordpress.org
Tue Mar 22 16:38:05 UTC 2016


#35715: edit_user() doesn't check for empty password (pass1).
-------------------------------------------------+-------------------------
 Reporter:  gitlost                              |       Owner:
     Type:  defect (bug)                         |  SergeyBiryukov
 Priority:  normal                               |      Status:  reviewing
Component:  Users                                |   Milestone:  4.5
 Severity:  normal                               |     Version:  4.4
 Keywords:  good-first-bug has-patch has-        |  Resolution:
  screenshots                                    |     Focuses:
-------------------------------------------------+-------------------------
Changes (by ocean90):

 * keywords:  good-first-bug has-patch has-screenshots commit => good-first-
     bug has-patch has-screenshots


Comment:

 "Enter '''your''' password…" doesn't make sense here, should be "Enter
 '''a''' password…" I think.

 > Add an additional check for blank passwords in the later conditional
 that checks pass1 vs. pass2, without this entering a password in field2
 while leaving field 1 blank would result in a double error message:

 Related: #33101

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35715#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list