[wp-trac] [WordPress Trac] #36281: Importer Fails to import menu items in PHP7

[WordPress Trac]

#36281: Importer Fails to import menu items in PHP7
--------------------------+----------------------------
 Reporter:  mightyturtle  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  WordPress.org
Component:  Import        |     Version:  4.0
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+----------------------------
Changes (by SergeyBiryukov):

 * milestone:  Awaiting Review => WordPress.org


Old description:

> The Wordpress importer plugin fails to import menu items at all with PHP
> 7 (any WP version). It's a pretty quick fix, though.
>
> I noticed this as part of writing a fix for the importer on wp-cli:
> https://github.com/wp-cli/wp-cli/pull/2545#issuecomment-199026539
>
> But it was noticed by others, a couple months ago, and a fix provided:
> https://wordpress.org/support/topic/importer-fails-to-import-menu-items-
> in-php7?replies=6
>
> Since PHP7 has now been officially released for a few months, we're going
> to see more and more PHP7 installs pop up.
>
> To sum it up:
> wordpress-importer.php on line 798
> Change:
> $$meta['key'] = $meta['value'];
> To:
> ${$meta['key']} = $meta['value'];

New description:

 The WordPress Importer plugin fails to import menu items at all with PHP 7
 (any WP version). It's a pretty quick fix, though.

 I noticed this as part of writing a fix for the importer on wp-cli:
 https://github.com/wp-cli/wp-cli/pull/2545#issuecomment-199026539

 But it was noticed by others, a couple months ago, and a fix provided:
 https://wordpress.org/support/topic/importer-fails-to-import-menu-items-
 in-php7?replies=6

 Since PHP7 has now been officially released for a few months, we're going
 to see more and more PHP7 installs pop up.

 To sum it up:
 wordpress-importer.php on line 798
 Change:
 {{{
 $$meta['key'] = $meta['value'];
 }}}
 To:
 {{{
 ${$meta['key']} = $meta['value'];
 }}}

--

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36281#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform