[wp-trac] [WordPress Trac] #35947: Customizer panel fails to fully expand leaving extra margin

WordPress Trac noreply at wordpress.org
Sat Mar 19 11:48:22 UTC 2016


#35947: Customizer panel fails to fully expand leaving extra margin
-----------------------------------+-----------------------------
 Reporter:  tronoxas               |       Owner:  delawski
     Type:  defect (bug)           |      Status:  assigned
 Priority:  normal                 |   Milestone:  Future Release
Component:  Customize              |     Version:  4.4.2
 Severity:  normal                 |  Resolution:
 Keywords:  needs-patch 4.6-early  |     Focuses:
-----------------------------------+-----------------------------

Comment (by delawski):

 I have looked into this issue for the second time.

 It was really hard for me to replicate the problem. Thanks to @westonruter
 and @rheinardkorf instructions I was able to notice it, but only in case
 of refocusing on nav item after focusing on any widget.

 I have slightly refactored focus method in {{{customize-nav-menus.js}}}.
 Now, if initial {{{focus()}}} fails (due to inputs and other focusable
 elements not being {{{:visible}}}), another {{{focus()}}} attempt is made
 with delay. Please, see the actual commit:

 https://github.com/xwp/wordpress-
 develop/pull/145/commits/7f607e7c0882ab155cff072ec6b6c7ebd309c962

 I know this isn't the most elegant solution. However, since:
 - this is an edge-case,
 - #34391 targeted at early-4.6 is going change the way elements are
 focused,
 - this ticket fixes other, much more evident issues (slight horizontal and
 huge vertical gaps when the number of panels/sections is high enough),
 then I suggest keeping it in 4.5 rather punting to early-4.6.

 Anyway, it'd be great if someone else ( @ryankienstra , @rheinardkorf )
 would check if latest update fixes remaining issues. Here's the link to
 the PR:

 https://github.com/xwp/wordpress-develop/pull/145

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35947#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list