[wp-trac] [WordPress Trac] #35855: Let selective refresh component be required but be opt-in for sidebars/widgets (for now)

[WordPress Trac]

#35855: Let selective refresh component be required but be opt-in for
sidebars/widgets (for now)
-------------------------------------+--------------------------
 Reporter:  DrewAPicture             |       Owner:  westonruter
     Type:  task (blessed)           |      Status:  accepted
 Priority:  normal                   |   Milestone:  4.5
Component:  Customize                |     Version:  trunk
 Severity:  blocker                  |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+--------------------------
Changes (by westonruter):

 * keywords:  has-patch => has-patch needs-testing


Comment:

 Work in progress on implementing the per-sidebar opt-in:
 [attachment:35855.2.diff]

 It's proving to be much more difficult than I expected to go the route of
 per-sidebar opt-in, as there are a lot more edge cases compared with a
 global on/off. The one known issue not yet addressed in this patch is
 properly previewing the move of a widget from a non-selective-refreshed
 sidebar to a selective-refreshed sidebar. The selective refresh is getting
 initiated in the an iframe that is being destroyed, and so when the new
 iframe is loaded it loads without the widget placed in the new sidebar.

 If it is really a toss-up between the `add_theme_support()` and the
 `register_sidebar()` route, it would simplify things a lot if we just went
 with the former.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35855#comment:46>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform