[wp-trac] [WordPress Trac] #36255: Custom Logo: Crop UI

WordPress Trac noreply at wordpress.org
Fri Mar 18 22:18:40 UTC 2016

#36255: Custom Logo: Crop UI
 Reporter:  mor10                  |       Owner:  obenland
     Type:  defect (bug)           |      Status:  assigned
 Priority:  normal                 |   Milestone:  4.5
Component:  Customize              |     Version:  trunk
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:  ui
Changes (by westonruter):

 * owner:  westonruter => obenland
 * status:  accepted => assigned


 @celloexpressions so then really what you've identified is that the theme
 support feature for `custom-logo` should have better alignment with the
 existing feature arguments for `custom-header`? In Twenty Sixteen, the
 custom header support is added via:

 add_theme_support( 'custom-header', apply_filters(
 'twentysixteen_custom_header_args', array(
         'default-text-color'     => $default_text_color,
         'width'                  => 1200,
         'height'                 => 280,
         'flex-height'            => true,
         'wp-head-callback'       => 'twentysixteen_header_style',
 ) ) );

 So the `custom-header` supports `flex-height` and `flex-width` arguments,
 as well as `width` and `height` arguments. You're saying that these should
 be used for Custom Logo instead of adding a custom image size and
 referencing its name. I suppose the feature could allow the size to be
 defined via a `size` argument as it is now, or the dimensions could be
 defined via attributes like `custom-header` accepts.

 As for how custom logo relates to custom header, I'll defer to @obenland.

Ticket URL: <https://core.trac.wordpress.org/ticket/36255#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list