[wp-trac] [WordPress Trac] #35030: Responsive Images: wrong source selected in iOS8
WordPress Trac
noreply at wordpress.org
Fri Mar 18 19:51:32 UTC 2016
#35030: Responsive Images: wrong source selected in iOS8
--------------------------------------+------------------------
Reporter: tonysandwich | Owner: joemcgill
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 4.5
Component: Media | Version: 4.4
Severity: normal | Resolution: fixed
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+------------------------
Comment (by jaspermdegroot):
@azaozz
Yeah, you're completely right about
`test_wp_calculate_image_srcset_src_first()`. I wrote it right after
fixing the bug not thinking about the fact that most existing tests would
fail and that fixing them results in testing this. And I also see the
problems with using that shuffle now. Although I think it wouldn't cause
random failure but more a false positive.
Anyways, it's a bad/useless test. Thanks for the feedback! I learned
something :)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35030#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list