[wp-trac] [WordPress Trac] #35030: Responsive Images: wrong source selected in iOS8
WordPress Trac
noreply at wordpress.org
Fri Mar 18 09:38:22 UTC 2016
#35030: Responsive Images: wrong source selected in iOS8
--------------------------------------+------------------------
Reporter: tonysandwich | Owner: joemcgill
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 4.5
Component: Media | Version: 4.4
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+------------------------
Comment (by jaspermdegroot):
Replying to @azaozz, @johnbillion, and @joemcgill:
Good point about page caching. So let's indeed not do something for iOS(8)
specific.
Just to put things in perspective: 1% of ~3.5 billion internet users is
still 35 million people. It's a bigger market share than whole Windows
Phone. These are probably mostly people that have an iThing that can't be
upgraded to iOS9 so I think the number won't decrease very fast either. If
it was about iOS8 users not benefiting from an enhancement it would be a
different story, but here we are breaking something that used to be ok. So
I really think we should fix this.
In 35030.3.patch: Instead of using two arrays, prepend the src image to
the `$sources` array. Compared to @azaozz his patch I used the `+`
operator instead `array_merge()` because of the difference in how
duplicate keys are handled.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35030#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list