[wp-trac] [WordPress Trac] #36084: Link to media images now get a rel=attachment

[WordPress Trac]

#36084: Link to media images now get a rel=attachment
--------------------------------------+------------------------
 Reporter:  csschris                  |       Owner:  joemcgill
     Type:  defect (bug)              |      Status:  accepted
 Priority:  normal                    |   Milestone:  4.5
Component:  Media                     |     Version:  4.4.2
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+------------------------

Comment (by azaozz):

 Replying to [comment:18 joemcgill]:
 > My preference currently would be to keep the changes introduced last
 cycle, and do [attachment:36084.3.diff] with an added sanity check to make
 sure the value is a string. The logic seems more straightforward to me and
 removes the confusing redundancy that existed before [34259] (et al.).

 Yeah, it's similar to 36084.3.diff.

 I'm 50/50 on whether we need to support string there. It was added for no
 good reason (to match the docs?) and is very doubtful anything is using
 it.

 However we should not change how that parameter works, only revert. The
 bug is that in [34259] the boolean was reversed. However `$rel` has been a
 boolean for many years. There is no good reason to change it even more.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36084#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform