[wp-trac] [WordPress Trac] #36255: Custom Logo: Crop UI

[WordPress Trac]

#36255: Custom Logo: Crop UI
--------------------------+--------------------
 Reporter:  mor10         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.5
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+--------------------

Comment (by celloexpressions):

 I don't think logos should support crop by default, because the image
 being uploaded is theoretically already cropped appropriately as a logo.
 Additionally, themes can't define the exact dimensions of the requested
 logo directly (only via the image size and the crop option there). The
 general principle is currently that themes should be able to handle a
 variety of logo aspect ratios so that the content (the logo image) can be
 presented in its intended format rather than needing to be adjusted
 (cropped) to fit properly in the theme.

 If there are problems with the way themes are implementing this, I would
 recommend revisiting the way themes can specify logo sizes, and finding a
 way to prevent themes from automatically cropping images. Logos should be
 presented at whatever size the theme requires, but themes shouldn't be
 modifying the logo aspect ratio/image content. At most the theme could
 provide recommended dimensions to design the image to before uploading.

 This would also add a step to the user flow whenever a logo is added,
 asking if the user wants to crop their image rather than setting it as
 soon as it's selected from the media library. Letting users crop logos
 doesn't solve the problem here - the logo would then still end up being
 partially cut off if it were the wrong aspect ratio and would likely need
 to be redesigned outside of WordPress anyway.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36255#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform