[wp-trac] [WordPress Trac] #36256: Custom Logo: Customizer display should match theme crop
WordPress Trac
noreply at wordpress.org
Wed Mar 16 19:23:36 UTC 2016
#36256: Custom Logo: Customizer display should match theme crop
--------------------------+------------------------------
Reporter: mor10 | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Customize | Version: trunk
Severity: normal | Resolution:
Keywords: | Focuses:
--------------------------+------------------------------
Comment (by westonruter):
I'm not entirely sure about this. I think it makes sense that the preview
is where the actual image size is used since that is where the preview is
happening. The image appearing in the control would be more “meta” to
indicate which image is chosen, not exactly how it appears. Otherwise, the
same image would be displayed twice. Compare, for example, the site title
and tagline: the text boxes show the raw database value whereas the
preview shows the values as filtered by `wptexturize` and whatever the
theme & plugins are doing.
If the actual image size for the logo were to be used in the control, it
would require a couple changes:
1) The `\WP_Customize_Media_Control::content_template` is hard-coded to
use the `medium` or `full` image sizes. So it would have to be updated to
allow other image sizes to be used:
https://core.trac.wordpress.org/browser/tags/4.4.2/src/wp-
includes/customize/class-wp-customize-media-control.php?marks=161-164#L154
2) The change in [36839] would need to be reverted/modified to allow the
custom image sizes to be returned in Ajax requests. See #36096.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/36256#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list