[wp-trac] [WordPress Trac] #36096: Custom Logo: Improper image size appears momentarily after selection
WordPress Trac
noreply at wordpress.org
Mon Mar 14 19:16:12 UTC 2016
#36096: Custom Logo: Improper image size appears momentarily after selection
------------------------------+--------------------------
Reporter: westonruter | Owner: westonruter
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 4.5
Component: Customize | Version: trunk
Severity: normal | Resolution: fixed
Keywords: has-patch commit | Focuses:
------------------------------+--------------------------
Changes (by westonruter):
* status: accepted => closed
* resolution: => fixed
Comment:
In [changeset:"36990"]:
{{{
#!CommitTicketReference repository="" revision="36990"
Customize: Rely on selective refresh exclusively for previewing custom
logo changes.
Eliminates JS logic (from [36698]) which attempted to do pure JS update
while waiting for the selective refresh response to return. The duplicate
JS logic lacked a re-implementation of the `image_downsize()`
functionality available in PHP, and so the JS preview logic would fail to
properly preview images that didn't have the exact theme image size
generated. To keep the code DRY and to eliminate the momentary display of
an improperly-sized image, the duplicated JS logic is now removed.
See #27355.
See #33755.
Fixes #36096.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/36096#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list