[wp-trac] [WordPress Trac] #30468: wplink modal accessibility

[WordPress Trac]

#30468: wplink modal accessibility
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  high                     |   Milestone:  Future Release
Component:  Editor                   |     Version:  4.0
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch has-           |     Focuses:  ui, accessibility,
  screenshots                        |  javascript
-------------------------------------+-------------------------------------
Changes (by afercia):

 * keywords:  needs-testing dev-feedback => has-patch has-screenshots


Comment:

 Many things have changed in the link modal dialog, see #33301. It is now
 greatly simplified and that makes things easier for accessibility too. Now
 that #33301 is going to be shipped with WordPress 4.5 I'd recommend the
 refreshed patch for commit consideration. It does a few, simple, things:
 - adds a `role="dialog"` and an `aria-labelledby` attribute to the modal
 container
 - changes the modal title in a `h1`
 - removes one ` ` that gets read out as "blank" by screen readers
 - changes the "Cancel" link in a button
 - removes some no more used CSS

 Screenshot before and after the patch:

 [[Image(https://cldup.com/2xBoKzhdMa.png)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30468#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform