[wp-trac] [WordPress Trac] #35480: Some notice and warning in wp_calculate_image_srcset() function media.php

WordPress Trac noreply at wordpress.org
Sun Mar 13 21:48:40 UTC 2016


#35480: Some notice and warning in wp_calculate_image_srcset() function media.php
----------------------------------------+------------------------
 Reporter:  overclokk                   |       Owner:  joemcgill
     Type:  defect (bug)                |      Status:  accepted
 Priority:  normal                      |   Milestone:  4.5
Component:  Media                       |     Version:  4.4.1
 Severity:  normal                      |  Resolution:
 Keywords:  needs-unit-tests has-patch  |     Focuses:  template
----------------------------------------+------------------------
Changes (by jaspermdegroot):

 * keywords:  needs-unit-tests needs-patch => needs-unit-tests has-patch


Comment:

 35480.patch checks if `$image` is an array and if file name isn't
 corrupted (if it contains a `.` and at least one character in front of
 it).

 Note that in the report of @ocean90 only the file name of the full size
 image was corrupted, while this patch checks the file name of each image
 size. I was in doubt whether we should play safe and check all or only
 check the file name of the full size image until someone reports a bug
 that the file name of an image size is corrupted.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35480#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list