[wp-trac] [WordPress Trac] #34945: HTTPS website with HTTP images

[WordPress Trac]

#34945: HTTPS website with HTTP images
-------------------------------------------------+-------------------------
 Reporter:  Angristan                            |       Owner:
     Type:  defect (bug)                         |  johnbillion
 Priority:  normal                               |      Status:  reopened
Component:  Media                                |   Milestone:  4.5
 Severity:  normal                               |     Version:  4.4
 Keywords:  https has-patch has-unit-tests       |  Resolution:
  needs-testing                                  |     Focuses:
-------------------------------------------------+-------------------------

Comment (by thomaswm):

 Replying to [comment:54 jeremyfelt]:
 > * `wp_calculate_image_srcset()` to reverse with a content context.

 That function should not use the content context. Unlike
 `get_image_tag()`, the URLs generated by `wp_calculate_image_srcset()` are
 never stored in the database. They are generated on-the-fly when a post is
 displayed. Therefore, they should inherit the scheme from the current
 request.

 Otherwise, we would re-introduce the problem which was reported in this
 ticket:
 > And now with the 4.4 update I have a new bug : some images are loaded
 with the srcset attribute, but in HTTP... and I can't fix that

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34945#comment:55>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform