[wp-trac] [WordPress Trac] #33305: Plugin details modal: initial focus and constraining tabbing

[WordPress Trac]

#33305: Plugin details modal: initial focus and constraining tabbing
------------------------------+--------------------------------------------
 Reporter:  afercia           |       Owner:  afercia
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  4.5
Component:  Plugins           |     Version:  4.2
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:  ui, accessibility, javascript
------------------------------+--------------------------------------------
Changes (by afercia):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"36964"]:
 {{{
 #!CommitTicketReference repository="" revision="36964"
 Accessibility: Improve accessibility for the Plugin details modal.

 The plugin details modal can be invoked from several screens. There's now
 a new
 `.open-plugin-details-modal` CSS class to be used in combination with the
 `.thickbox` CSS class that adds everything needed for accessibility.

 - Adds an ARIA role `dialog` and an `aria-label` attribute to the modal
 - Adds a `title` attribute to the iframe inside the modal
 - Constrains tabbing within the modal
 - Restores focus back in a proper place when closing the modal

 Also, improves a bit the native Thickbox implementation: it should
 probably be
 replaced with some more modern tool but at least keyboard focus should be
 moved
 inside the modal.

 Fixes #33305.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33305#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform