[wp-trac] [WordPress Trac] #35947: Customizer panel fails to fully expand leaving extra margin
WordPress Trac
noreply at wordpress.org
Thu Mar 10 14:03:15 UTC 2016
#35947: Customizer panel fails to fully expand leaving extra margin
-----------------------------------------+---------------------------
Reporter: tronoxas | Owner: ryankienstra
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.5
Component: Customize | Version: 4.4.2
Severity: normal | Resolution:
Keywords: has-patch reporter-feedback | Focuses:
-----------------------------------------+---------------------------
Comment (by delawski):
@westonruter - I have investigated an issues with wrong element being
focused inside widget controls after shift-click. I've noticed that the
problem was present there earlier and is not related to this ticket (you
could checkout master branch and see the same issue).
I have, however, found out that [https://github.com/xwp/wordpress-
develop/commit/81b7b76a7c0b6d9bf4e5ee7482efa66cd6cca554 the order of
focusable elements is wrong]. For some reason anchor tag was picked as the
first element to focus on.
So what I did is split the procedure for finding focusable elements into
two stages:
1. Find first visible input, textarea, button or select.
2. If no such form element is found, search for any anchor, object or
other element having tabindex property.
[https://github.com/xwp/wordpress-develop/pull/145 You can see the changes
in the same PR, the latest commit.]
I couldn't find any better, more elegant solution. I'm open to other
ideas.
[https://core.trac.wordpress.org/attachment/ticket/35947/35947.5.patch
I've attached a patch file with the latest update.]
@ryankienstra - Could you, please, take a look at the solution and confirm
it's working for you?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35947#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list