[wp-trac] [WordPress Trac] #36186: users.php and upload.php "Add New" links do not use admin_url()

[WordPress Trac]

#36186: users.php and upload.php "Add New" links do not use admin_url()
-----------------------------+-----------------------------------
 Reporter:  johnjamesjacoby  |      Owner:
     Type:  enhancement      |     Status:  new
 Priority:  normal           |  Milestone:  Awaiting Review
Component:  Administration   |    Version:  2.0
 Severity:  normal           |   Keywords:  has-patch 2nd-opinion
  Focuses:  administration   |
-----------------------------+-----------------------------------
 Unlike `edit.php` (and most of the multisite files that use
 `network_admin_url()`) both `users.php` and `upload.php` use relative file
 paths when linking to "Add New" in the `h1` tag.

 This has two implications for edge (but still plausible) use cases, that
 also in/conveniently coincide with something I'm working on currently:
 * Plugins cannot intercept these URLs to introduce query strings or other
 functionalities like they can in all other places `admin_url()` and
 `network_admin_url()` are used.
 * Custom `wp-admin` paths do not obey, as filters applied to `admin_url()`
 are not ran

 I'd like to propose these two files use `admin_url()` vs. relative paths,
 with an imminent patch.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36186>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform