[wp-trac] [WordPress Trac] #35362: Empty `items_wrap` `wp_nav_menu` randomly breaks customizer
WordPress Trac
noreply at wordpress.org
Wed Mar 9 00:08:53 UTC 2016
#35362: Empty `items_wrap` `wp_nav_menu` randomly breaks customizer
--------------------------+--------------------------
Reporter: ojrask | Owner: westonruter
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 4.5
Component: Customize | Version: 4.4
Severity: normal | Resolution: fixed
Keywords: has-patch | Focuses:
--------------------------+--------------------------
Changes (by westonruter):
* status: accepted => closed
* resolution: => fixed
Comment:
In [changeset:"36889"]:
{{{
#!CommitTicketReference repository="" revision="36889"
Customize: Fix regressions and harden implementation of selective refresh
for nav menus.
* Request full refresh if there are nav menu instances that lack partials
for a changed setting.
* Restore `WP_Customize_Nav_Menus::$preview_nav_menu_instance_args` and
`WP_Customize_Nav_Menus::export_preview_data()` from 4.3, and keeping a
tally of all `wp_nav_menu()` calls regardless of whether they can use
selective refresh.
* Ensure that all instances of `wp_nav_menu()` are tallied, regardless of
whether they are made during the initial preview call or during subsequent
partial renderings. Export `nav_menu_instance_args` with each partial
rendering response just as they are returned when rendering the preview as
a whole.
* Fix issues with Custom Menu widget where nav menu items would fail to
render when switching between menus when a menu lacked items to begin
with.
* Make sure the fallback behavior is invoked when the partial is no longer
associated with a menu.
* Do fallback behavior to refresh preview when all menu items are removed
from a menu.
Follows [36586].
See #27355.
Fixes #35362.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35362#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list