[wp-trac] [WordPress Trac] #35874: XMLRPC: Draft posts are published immediately when changed to published and future-dated at once
WordPress Trac
noreply at wordpress.org
Tue Mar 8 20:33:41 UTC 2016
#35874: XMLRPC: Draft posts are published immediately when changed to published and
future-dated at once
--------------------------------------+--------------------------
Reporter: redsweater | Owner: rachelbaker
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.5
Component: XML-RPC | Version: 4.4
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+--------------------------
Comment (by redsweater):
@rachelbaker The whole mess of code makes my head hurt, so I tried to
solve it in as straight-forward a way as I could without rethinking it too
much. My thinking was it's better to fix it in the core method because
that would protect against a similar bug affecting other clients to that
function. For example, maybe the REST API will use it? Also, I don't
completely understand the convention of the 00'd out date strings, nor am
I confident it's a 100% reliable way to test for whatever case they are
trying to cover here, but the fact that extending the test to cover
post_date keeps the logic identical except for also extending it to that
field, made me most comfortable in submitting a patch I could defend :)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35874#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list