[wp-trac] [WordPress Trac] #36086: Custom Logo: Add unit tests

WordPress Trac noreply at wordpress.org
Mon Mar 7 21:19:07 UTC 2016


#36086: Custom Logo: Add unit tests
----------------------------+-----------------------
 Reporter:  obenland        |       Owner:  jorbin
     Type:  task (blessed)  |      Status:  assigned
 Priority:  normal          |   Milestone:  4.5
Component:  Customize       |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+-----------------------

Comment (by jorbin):

 `test_the_custom_logo` feels like it's just making sure that
 `the_custom_logo` is a wrapper to echo `get_custom_logo`.  Would it make
 more sense to test expected HTML output?

 Calling `_remove_custom_logo()` after an assertion means that it may not
 be run if the assertion fails. We should add that to the teardown.

 Tests_WP_Custom_Logo  doesn't use the `wp_custom_logo` property.  Looks
 like it can be eliminated.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36086#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list