[wp-trac] [WordPress Trac] #35667: Maximum execution time error in WP_Text_Diff_Renderer_Table

[WordPress Trac]

#35667: Maximum execution time error in WP_Text_Diff_Renderer_Table
-------------------------------------+-----------------------
 Reporter:  ocean90                  |       Owner:  ocean90
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  4.5
Component:  Revisions                |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+-----------------------
Changes (by codex-m):

 * keywords:  has-patch => has-patch needs-testing


Comment:

 @ocean90 Yep it will work..

 @subharanjan We have same thoughts on custom implementation for
 levenshtein(). Only that mbstring is a non-default extension:
 http://php.net/manual/en/mbstring.installation.php

 We should check if the server supports and that mb_strlen is available. If
 not add a compatible workaround. I followed similar concepts to GlotPress
 here: https://github.com/GlotPress/GlotPress-
 WP/blob/679d500e5ffbdfed6ac124481780205c3b7854d9/gp-
 includes/strings.php#L28

 Extending your custom implementation, I added the 35667.3.patch

 I tested this locally and it works also. :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35667#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform