[wp-trac] [WordPress Trac] #35362: Empty `items_wrap` `wp_nav_menu` randomly breaks customizer

WordPress Trac noreply at wordpress.org
Mon Mar 7 07:03:06 UTC 2016


#35362: Empty `items_wrap` `wp_nav_menu` randomly breaks customizer
--------------------------+--------------------------
 Reporter:  ojrask        |       Owner:  westonruter
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  4.5
Component:  Customize     |     Version:  4.4
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+--------------------------
Changes (by westonruter):

 * keywords:  has-patch => needs-patch


Comment:

 There is a different problem now with the merge of selective refresh. No
 longer will the menu get duplicated. Now the problem is that when a
 `wp_nav_menu()` is called in a way that it cannot be selective-refreshed,
 then it will fail to get a full page refresh. This means that changes to
 such menus currently cannot be previewed in 4.5-beta2.

 Some of the logic removed in [36586] may need to be restored, specifically
 the logic which kept a tally of the total number of `wp_nav_menu()` calls
 not just those which can use selective refresh.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35362#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list