[wp-trac] [WordPress Trac] #34344: Expanded section margin-top glitches when other section is deactivated
WordPress Trac
noreply at wordpress.org
Sun Mar 6 05:42:55 UTC 2016
#34344: Expanded section margin-top glitches when other section is deactivated
--------------------------+---------------------------
Reporter: westonruter | Owner: ryankienstra
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.5
Component: Customize | Version: 4.2
Severity: normal | Resolution:
Keywords: needs-patch | Focuses: javascript
--------------------------+---------------------------
Changes (by westonruter):
* owner: westonruter => ryankienstra
Comment:
@ryankienstra @delawski This is closely related to what you've been
working on for #35947.
In fact, I would have thought that @ryankienstra's [https://github.com/xwp
/wordpress-develop/pull/145 PR] would have fixed the issue as it
describes:
> This occurs when there are many panels, using the code provided in the
ticket to produce the panels. The non-active sections and panels still
occupied space in the DOM. So the active panel had a margin-top property
to move it to the top. This PR sets the height of the non-active sections
to 0. And it doesn't add a margin-top value to the active panel's content.
Nevertheless, the issue also happens with [https://github.com/xwp
/wordpress-develop/commit/334473cb0975541e7b46935caa50061ec235fd45
334473c] checked out.
Your experience here is appreciated. If it's not something that can be
figured out over the next several days, this is probably something that
we'll need to punt for the next release.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/34344#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list