[wp-trac] [WordPress Trac] #35945: Site Logo: reconsider the `site` terminology in code
WordPress Trac
noreply at wordpress.org
Sun Mar 6 02:48:31 UTC 2016
#35945: Site Logo: reconsider the `site` terminology in code
------------------------------+-----------------------
Reporter: celloexpressions | Owner: obenland
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 4.5
Component: Customize | Version: trunk
Severity: normal | Resolution:
Keywords: commit has-patch | Focuses:
------------------------------+-----------------------
Comment (by iamtakashi):
@westonruter
That's another good point. And +1 for the patch.
----
Anyway, in my mind, this isn't about how easy for a theme to deal with it.
Whether we like it or not, many themes already have custom body classes
for various reasons. Even most of default themes have more than one.
That's the reality.
While we generally prise simplicity in themes, why do we want to make
themes carry more code? Many theme creators are constantly putting effort
to create something new and appealing design while keeping theme code as
simple as possible. I guess what I'm trying to say is an argument like
"majority of theme wouldn't need it" is just a speculation.
In the end, themes can deal with it even if we decided to not to add back
the body class. But I personally would like it to be added back for the
reason I have mentioned.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35945#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list