[wp-trac] [WordPress Trac] #31127: Can't add a new user to two sites before they've accepted their account

[WordPress Trac]

#31127: Can't add a new user to two sites before they've accepted their account
-------------------------------------------------+-------------------------
 Reporter:  ericlewis                            |       Owner:  jeremyfelt
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  Future
Component:  Users                                |  Release
 Severity:  normal                               |     Version:  3.0
 Keywords:  has-patch needs-unit-tests needs-    |  Resolution:
  testing                                        |     Focuses:  multisite
-------------------------------------------------+-------------------------
Changes (by jeremyfelt):

 * keywords:  has-patch needs-unit-tests => has-patch needs-unit-tests
     needs-testing
 * milestone:  4.5 => Future Release


Comment:

 We probably want to wait. Things are so funky around signups.

 With [attachment:31127.diff] applied:

 * When adding the user to a second site, a new email notification is sent
 out with a new, but invalid, activation key. We should make sure that any
 additional emails have the same activation key that is attached to the
 main `wp_signups` record.
 * Even with a pending activation, it's possible to add the user to a new
 site and skip the confirmation process. This leaves a signup in a pending
 state. Can we warn the admin and then automatically activate the other
 signup(s)?
 * If I add a pending user and skip the confirmation the confirmation
 process and they then activate their account, their password notification
 seems to never arrive. (In my single test with Mailcatcher)

 Replying to [comment:2 ericlewis]:
 > On a related note, it's odd that a site administrator is choosing a
 username for another person. An email is an existing, (relatively) unique
 identifier for this person. Preferably that person can choose their
 username. Removing that might help here. Two separate site admins might
 invite a person using the same email address, but might pick different
 usernames for them.

 It makes sense in some ways, though it would be useful to allow for
 multiple workflows here. The entire Add New User screen is confusing in
 this way. That you even have to choose between adding an existing and new
 user to begin with drives me crazy. Expanding on that would start to
 hijack this ticket though. :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31127#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform