[wp-trac] [WordPress Trac] #34747: Provide more flexibility for "You are customizing" text

WordPress Trac noreply at wordpress.org
Sat Mar 5 04:22:01 UTC 2016


#34747: Provide more flexibility for "You are customizing" text
-----------------------------+-----------------------------
 Reporter:  danielbachhuber  |       Owner:  ryankienstra
     Type:  enhancement      |      Status:  assigned
 Priority:  normal           |   Milestone:  Future Release
Component:  Customize        |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:
-----------------------------+-----------------------------

Comment (by ryankienstra):

 '''Updated Patch And PR'''

 Hi @westonruter,
 Thanks for looking at my
 [https://core.trac.wordpress.org/attachment/ticket/34747/a842df4.diff
 previous patch]. Here is an
 [https://core.trac.wordpress.org/attachment/ticket/34747/2007d00.diff
 updated patch] and [https://github.com/xwp/wordpress-
 develop/pull/143/commits pull request].

 As you requested, this uses [https://github.com/xwp/wordpress-
 develop/pull/143/files#diff-4fb8a477f559bdfad2c1e6db6d1c8b06R1638
 WP_Customize_Manager] to `set` and `get` the Customizer
 [https://github.com/xwp/wordpress-develop/pull/143/files#diff-
 4fb8a477f559bdfad2c1e6db6d1c8b06R1659 title] and [https://github.com/xwp
 /wordpress-develop/pull/143/files#diff-
 4fb8a477f559bdfad2c1e6db6d1c8b06R1711 description]. It
 [https://github.com/xwp/wordpress-develop/pull/143/files#diff-
 4fb8a477f559bdfad2c1e6db6d1c8b06R1848 adds] these values to an array,
 which is available in [https://github.com/xwp/wordpress-
 develop/pull/143/files#diff-58dfe22165ffd9650354f7bdd51002ecR3253
 customize-controls.js] as `api.settings`.

 This file also [https://github.com/xwp/wordpress-develop/pull/143/files
 #diff-58dfe22165ffd9650354f7bdd51002ecR3257 hides] the "help" button if
 there's no description. And it [https://github.com/xwp/wordpress-
 develop/pull/143/files#diff-58dfe22165ffd9650354f7bdd51002ecR3678 hides]
 the entire `.customize-panel-description` section if there's no title.

 There are new [https://github.com/xwp/wordpress-develop/pull/143/files
 #diff-7ab28a2bee855d3893686a7a245b8440R343 unit tests] for all of the new
 [https://github.com/xwp/wordpress-develop/pull/143/files#diff-
 4fb8a477f559bdfad2c1e6db6d1c8b06R1638 WP_Customize_Manager] methods.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34747#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list