[wp-trac] [WordPress Trac] #33755: Add Site Logo to WordPress Core

[WordPress Trac]

#33755: Add Site Logo to WordPress Core
-------------------------------------------------+-------------------------
 Reporter:  fatmedia                             |       Owner:  obenland
     Type:  task (blessed)                       |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.5
Component:  Customize                            |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  ux-feedback needs-unit-tests has-    |     Focuses:  ui
  screenshots needs-patch                        |
-------------------------------------------------+-------------------------

Comment (by fatmedia):

 Replying to [comment:131 karmatosed]:
 > @celloexpressions I see you say:
 >
 > "the wp-site-logo body class seems really excessive. Do we want to get
 locked in to having this? There are a lot of body classes already, and I
 don't think there would be common enough usage to warrant it in core; it
 could be added by a theme if there is a specific need for it."
 >
 > Actually for themers this is incredibly useful. I would strongly advise
 we revert this removal. It helps so much with positioning and stops us
 having to silly hacks and selector statements that are incredibly delicate
 and easily broken.

 I agree it can be useful, but I'm not sure it's important for core to add
 it by default. If a theme does need it for one reason or another, it's
 pretty quick to filter it in there.

 IMO it's also probably something that would be more useful when applied to
 the parent container around the logo rather than the body class. The rest
 of the site likely won't care whether a logo is present or not, but the
 site's main `<header>` element might, just an example.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33755#comment:134>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform