[wp-trac] [WordPress Trac] #35969: Twenty Fourteen: Add Site Logo Support
WordPress Trac
noreply at wordpress.org
Sat Mar 5 00:46:03 UTC 2016
#35969: Twenty Fourteen: Add Site Logo Support
---------------------------------------+--------------------
Reporter: celloexpressions | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.5
Component: Bundled Theme | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch has-screenshots | Focuses: ui
---------------------------------------+--------------------
Comment (by iamtakashi):
Replying to [comment:6 celloexpressions]:
In my opinion, the left sidebar isn't a good place for a logo. The sidebar
won't be there until 1008px wide viewport and the fact makes a logo need
to be hidden for small screens which is bad if you choose to hide your
site title in favour of your logo. Of course, there are things to solve
the issue with complicated logics but that would simply confuse users.
The only place, if we must to add, is the header where the site title is.
If a logo is thin rectangle shape could work but I'd say that's too
limiting when we offer an option like this. And it's worth to mention that
the sticky header will stop work if the header is more than 48px tall.
I wouldn't argue if the type of sites that uses Twenty Fourteen would or
wouldn't likely have a logo. But what I can say is that the theme wasn't
designed to have a logo that can be all sorts of sizes and shapes.
Therefore I'd suggest to not to add the support in this theme.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35969#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list