[wp-trac] [WordPress Trac] #35945: Site Logo: reconsider the `site` terminology in code
WordPress Trac
noreply at wordpress.org
Fri Mar 4 22:23:39 UTC 2016
#35945: Site Logo: reconsider the `site` terminology in code
--------------------------------------+-----------------------
Reporter: celloexpressions | Owner: obenland
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 4.5
Component: Customize | Version: trunk
Severity: normal | Resolution:
Keywords: needs-patch dev-feedback | Focuses:
--------------------------------------+-----------------------
Comment (by westonruter):
@karmatosed Regarding the `wp-site-logo` class used by Twenty Sixteen to
style the positioning of the logo, see comment from @celloexpressions in
https://core.trac.wordpress.org/ticket/33755#comment:102
> the `wp-site-logo` body class seems really excessive. Do we want to get
locked in to having this? There are a lot of body classes already, and I
don't think there would be common enough usage to warrant it in core; it
could be added by a theme if there is a specific need for it.
The issue I see with letting themes handle the adding of the body class is
that they would also have to make sure they handle this in the Customizer
preview dynamically when the custom logo is added or removed. This seems
unfortunate.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35945#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list