[wp-trac] [WordPress Trac] #33755: Add Site Logo to WordPress Core
WordPress Trac
noreply at wordpress.org
Fri Mar 4 22:22:01 UTC 2016
#33755: Add Site Logo to WordPress Core
-------------------------------------------------+-------------------------
Reporter: fatmedia | Owner: obenland
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 4.5
Component: Customize | Version: trunk
Severity: normal | Resolution:
Keywords: ux-feedback needs-unit-tests has- | Focuses: ui
screenshots needs-patch |
-------------------------------------------------+-------------------------
Comment (by karmatosed):
@celloexpressions I see you say:
"the wp-site-logo body class seems really excessive. Do we want to get
locked in to having this? There are a lot of body classes already, and I
don't think there would be common enough usage to warrant it in core; it
could be added by a theme if there is a specific need for it."
Actually for themers this is incredibly useful. I would strongly advise we
revert this removal. It helps so much with positions and stops us having
to silly hacks and selector statements that are incredibly delicate and
easily broken.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/33755#comment:131>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list