[wp-trac] [WordPress Trac] #36083: Media Grid: 'wp-admin/upload.php' broken in nightly builds

[WordPress Trac]

#36083: Media Grid: 'wp-admin/upload.php' broken in nightly builds
---------------------------------------------+-----------------------------
 Reporter:  joemcgill                        |       Owner:  joemcgill
     Type:  defect (bug)                     |      Status:  reopened
 Priority:  high                             |   Milestone:  4.5
Component:  Media                            |     Version:  trunk
 Severity:  major                            |  Resolution:
 Keywords:  has-patch has-unit-tests commit  |     Focuses:  administration
---------------------------------------------+-----------------------------
Changes (by ocean90):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 `'wp-admin/css/farbtastic-rtl.min.css'` wasn't added in 4.5, it doesn't
 get used at all.

 [[BR]]

 > It's testing that there are no such files, not that they must exist.

 Yes and no, add `wp-includes/css/customize-preview-rtl.min.css` to
 `$_old_files` as an example. Use case: We have changed a file which
 doesn't require an extra RTL stylesheet anymore, so we add the file to
 `$_old_files`.

 Also, `test_new_files_are_not_in_old_files_array` doesn't include
 *-rtl.css files. I think the
 `test_new_files_are_not_in_old_files_array_compiled` is the only test we
 need for this. It uses only 646 `file_exists()` checks while the other
 does has three for each file.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36083#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform