[wp-trac] [WordPress Trac] #37184: Stop FOUND_ROWS running in comment query is cached

[WordPress Trac]

#37184: Stop FOUND_ROWS running in comment query is cached
----------------------------------------+---------------------------
 Reporter:  spacedmonkey                |       Owner:  boonebgorges
     Type:  defect (bug)                |      Status:  reviewing
 Priority:  normal                      |   Milestone:  4.6
Component:  Comments                    |     Version:  4.4
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:
----------------------------------------+---------------------------
Changes (by boonebgorges):

 * keywords:  has-patch => has-patch needs-unit-tests
 * owner:   => boonebgorges
 * status:  new => reviewing
 * milestone:  Awaiting Review => 4.6


Comment:

 Introduced in [34544] but more obvious with persistent comment caching.
 This should be fixed for 4.6.

 I don't think there's any need to cache 'max_num_pages' since it can be
 calculated from found_comments.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37184#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform